CSE 341: Web Services

W05 Code Review: Review of Week 04 Pull Requests

Overview

• Purpose: Practice reviewing pull requests and providing useful feedback.
• Task: Follow the review instructions below and share your feedback with your team.

At the beginning of this week, review pull requests created by your teammates during Week 04.

For more information on the code review process, you can refer back to the Week 03 Learning Activity: Code Reviews. Each person must complete at least two GitHub reviews, and the team must make sure every PR receives a review and is merged after approval.

Required Review Content

For the code review assignments in this course, each code review you submit must include at least two meaningful statements. At least one statement should address behavior, testing, security, data modeling, or documentation.

A review that only says "looks good" is not enough. If the pull request is truly simple and correct, explain what you checked before approving it.

Instructions

1. Open your team's GitHub repository.
2. Open the Pull requests tab.
3. Find Week 03 PRs that are awaiting review.
4. Choose one PR and post in Microsoft Teams that you are reviewing it.
5. Watch the walk-through video that your teammate created.
6. Review the issue, PR description, changed files, and testing notes.
7. Submit a GitHub review with meaningful feedback or an approval summary.
8. Repeat until you have completed at least two reviews.
9. If all open PRs have already been reviewed, you may review a closed PR for additional practice and submission evidence.
10. Help your team make sure approved PRs are merged.

Code Review Checklist

Use this checklist while reviewing teammate PRs:

• The PR links to or mentions the GitHub issue.
• The PR description explains what changed.
• The PR description includes testing notes.
• The changed code matches the issue scope.
• The change follows existing project patterns.
• Mongoose models or queries are correct for the feature.
• Authentication or authorization checks are correct if the route is protected.
• Errors return safe JSON responses.
• Swagger documentation is updated if API behavior changed.
• No secrets or sensitive data were committed.

Submission

Return to Canvas and submit links to at least one GitHub review you completed this week.

Other Links:

• Return to: Week Overview | Course Home